-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Music: Redesign Part 2 #2337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Music: Redesign Part 2 #2337
Conversation
Alarm: Simplify alarm alerting screen (InfiniTimeOrg#2211)
…oach to switching between skipping and volume buttons
|
Build size and comparison to main:
|
|
I'm of the belief that track info isn't needed on a watch or should be at least be minimized to a progress bar. The buttons could them be laid out in a way that would make them easier to press. Just my 2 cents. |
|
@0x0000ff That being said, I think it's more important at this point to get the UI merged so people can actually start using it when the next version of InfiniTime is released... More changes can always be made in the future. |
Not quite sure what you mean by this. Care to elaborate? |
Agreed. Should be all good to merge from my side I think. |
mark9064
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good :)
Haven't tested locally or ran clang-tidy yet
Co-authored-by: mark9064 <30447455+mark9064@users.noreply.github.com>
…nto music_redesign_2
…nto music_redesign_2
mark9064
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much there I think :)
|
One other thing, could you edit the first message to show screenshots of the latest version? Just makes it a bit easier for anyone looking at the PR for the first time |
…g an array for the buttons and labels
|
I made the button labels a bit more gray when the buttons are disabled, so it’s easier to tell at a glance what’s inactive. I updated the first message of this PR as well so it matches the current UI, making it clearer for anyone checking it out for the first time - thanks for pointing that out @mark9064 :D |
|
Had a poke around, few suggestions here (mainly to avoid storing copies of all the buttons/labels again). I think the only substantial code change required is to fix the the progress bar narrowing issue, You can apply the changes locally with |
Totally didn't think of that, good catch. |

Hey everybody,
Since creating PR #2292 and introducing a small little redesign of the music app, I've had some more time on my hands and finally came around to creating a better version of it.
I've moved the artist and track name up a bit to add a new progress bar that shows the progress of the song you're listening to, with the time that has passed shown on the left and the time remaining shown on the right.
Sadly, I've had to remove (comment out) the disc animation in the top right because of space issues. If anyone is especially fond of the disc I'm sure space can be made to fit it back in. It is definitely not a final decision by me, hence why it's only commented out and not removed altogether.
But now that I've temporarily removed the disc animation, the top of the screen seemed quite empty to me. And after some thinking and digging through the code, I stumbled upon these lines of code in the Music.cpp:
And so I thought "why not do that?" and I added an indicator text at the top telling you if you are connected via bluetooth. Please share your opinion on this.
Finally, here are some pictures of it all:

