Fixed new ledger devices not detected when using the --ledger flag#10
Open
alex-tix wants to merge 1 commit intoInjectiveFoundation:masterfrom
Open
Fixed new ledger devices not detected when using the --ledger flag#10alex-tix wants to merge 1 commit intoInjectiveFoundation:masterfrom
alex-tix wants to merge 1 commit intoInjectiveFoundation:masterfrom
Conversation
|
Good stuff! |
|
@alex-tix thanks! you're a life saver! |
|
Closing this because it's been picked into v1.16.0 upcoming release. injective-core/injective-chain/crypto/ledger/hub/hub.go Lines 35 to 45 in fa901c7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems Ledger has added new product ids for new Ledger devices. By checking LedgerLive's device detection code, we can retrieve the new ones. The logic is much more convoluted in LedgerLive (for some unknown reason), but essentially the new product ID is the old one with 12 bits shifted to the left (eg. Nano X is both 0x0004 and 0x4000). You can verify this in the LedgerLive code (productIdMM value and bit shifting).
I've added the new product ids in the corresponding list and now new Ledger devices work correctly with injectived.