Skip to content

COMP: Update CI best practices and Python 3.10+#91

Merged
hjmjohnson merged 2 commits intomainfrom
update-ci-best-practices
Apr 14, 2026
Merged

COMP: Update CI best practices and Python 3.10+#91
hjmjohnson merged 2 commits intomainfrom
update-ci-best-practices

Conversation

@hjmjohnson
Copy link
Copy Markdown
Member

Update clang-format linter, actions/checkout@v5, Python 3.10+, fix @ghcr-mirror refs.

@hjmjohnson
Copy link
Copy Markdown
Member Author

WIP: test-linux-notebooks blocked on upstream Python 3.9 default.

The build-test-package-python.yml@v6.0b01 action defaults python3-minor-versions to ["9","10","11"], and the notebook test picks [0] = Python 3.9. This wheel requires >=3.10, so the install fails. Fix submitted upstream: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#126 (drop 3.9 from v6.0b01 defaults, matching what main already has).

All other CI checks pass. Once the upstream PR merges and CI re-runs, this PR should be green.

The v6.0b01 action defaults python3-minor-versions to ["9","10","11"].
The test-linux-notebooks job picks [0] = Python 3.9, but this wheel
declares requires-python >= 3.10, causing:

  ERROR: Package 'itk-splitcomponents' requires a different Python:
         3.9.25 not in '>=3.10'

Override to ["10","11"] at the module level.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Member Author

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to other PR approvals.

@hjmjohnson hjmjohnson merged commit 7724d63 into main Apr 14, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant