Add canonical log lines and structured JSON logging#301
Merged
Conversation
logging_instance emits a fixed pipe-delimited string with no JSON option and no trace/span fields, but OTel log-trace correlation needs trace_id / span_id per record. Add CanonicalLogLine (a Stripe-style wide-event accumulator with an injectable-clock timer), bind_trace_context, and a JSONLogFormatter that carries trace context. Wired through facade, executor (AC_canonical_log), MCP, and the Script Builder with a headless test batch and EN/Zh docs.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 31 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
logging_instanceemits a fixed pipe-delimited string with no JSON option and no trace/span fields, but OTel log-trace correlation needstrace_id/span_idper record.CanonicalLogLine— Stripe-style wide-event accumulator:add/update,timer(name)→{name}_ms(injectable clock),render/emit.bind_trace_context(line, ctx)— attaches aSpanContext's ids.JSONLogFormatter— alogging.Formatteremitting one JSON object per record includingtrace_id/span_idandextra=fields.The log-trace correlation counterpart to
trace_context.Layers
utils/canonical_log/(pure stdlibjson/logging, zero PySide6).__all__.AC_canonical_log.ac_canonical_log(read-only).test/unit_test/headless/test_canonical_log_batch.py(8 tests, injected clock).v93_features_doc.rst(EN + Zh) + toctrees + 3 README What's-new sections.Verification
pytest test/unit_test/headless/test_canonical_log_batch.py→ 8 passed.ruff check je_auto_control/clean; pylint 10.00/10; bandit clean; radon CC clean.