Add Unicode text normalisation and slugify#305
Merged
Conversation
fuzzy and search_index.tokenize only lowercase and OCR find_text_matches only .lower()+substring, so the same text in different Unicode forms (NFC/NFD), accents, or smart quotes compares unequal. Add normalize_text (NFKC + casefold + whitespace fold), deaccent, normalize_quotes, fold_whitespace, and slugify — the canonicalisation layer to run before matching. Wired through facade, executor (AC_normalize_text / AC_slugify), MCP, and the Script Builder with a headless test batch and EN/Zh docs.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 33 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
fuzzyandsearch_index.tokenizeonly lowercase, and OCRfind_text_matchesonly.lower()+substring — so"Café"(NFC) vs"Café"(NFD) vs"cafe"compare unequal. This adds the canonicalization layer to run before matching.normalize_text(text, *, form="NFKC", casefold=True, collapse_ws=True).deaccent,normalize_quotes(smart quotes/dashes/ellipsis/NBSP → ASCII),fold_whitespace,slugify(text, sep="-").Round-10 research pick (text-normalization lane);
unicodedatawas imported nowhere in text modules.Layers
utils/text_normalize/(pure stdlibunicodedata/re, zero PySide6).__all__.AC_normalize_text,AC_slugify.ac_normalize_text,ac_slugify(read-only).test/unit_test/headless/test_text_normalize_batch.py(10 tests, incl. NFC/NFD match).v97_features_doc.rst(EN + Zh) + toctrees + 3 README What's-new sections.Verification
pytest test/unit_test/headless/test_text_normalize_batch.py→ 10 passed.ruff check je_auto_control/clean; pylint 10.00/10; bandit clean; radon CC clean.