Add bidirectional-text QA with Trojan-source detection#319
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 51 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
confusablescatches lookalike characters, but invisible Unicode directional formatting (LRE/RLE/LRO/RLO/PDF, isolates LRI/RLI/FSI/PDI, marks LRM/RLM/ALM) can silently reorder how text renders — an RTL localisation-QA gap and the basis of the "Trojan Source" attack (CVE-2021-42574). This reports the bidi controls in a string, checks nesting balance, infers base direction, and flags Trojan-source-style formatting.Layers
je_auto_control/utils/bidi_check/bidi_check.py—bidi_controls,has_bidi_controls,is_balanced,base_direction,strip_bidi_controls,is_trojan_source,detect_bidi_issues. Pure stdlib (unicodedata), no PySide6. Control code points are built withchr()so the source itself holds no bidi characters (avoids Bandit B613 on the detector).is_balancedaliased tois_bidi_balanced) +__all__.AC_bidi_check→ report,AC_bidi_strip→ {text}.ac_bidi_check/ac_bidi_strip.CommandSpecs under Data.Tests / docs
test/unit_test/headless/test_bidi_check_batch.py— 9 headless tests (control listing, balance incl. mismatched close, base direction, strip, Trojan-source flag + wiring + facade). Controls built viachr().v111_features_doc.rst+ toctrees; 3 README What's-new sections.