Add check-digit algorithms (Luhn, Verhoeff, Damm, ISO 7064 MOD 97-10)#325
Merged
Conversation
Not up to standards ⛔
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Round-11 (research-driven).
pii_textdetects card/IBAN shapes by regex anddata_qualitydoes regex validation, but nothing computed or verified a check digit. This adds the shared arithmetic engine behind most real-world identifiers and the primitive that a futureidentifier_validate(IBAN/ISBN/EAN/card) builds on.Layers
je_auto_control/utils/checksum/checksum.py—luhn_validate/luhn_check_digit,verhoeff_*,damm_*,mod97_10_validate/mod97_10_check_digits. Pure stdlib (integer arithmetic; small embedded Verhoeff/Damm tables), no PySide6, pure functions.__all__.AC_checksum_validate→ {valid},AC_checksum_digit→ {check_digit}, via explicit scheme-dispatch dicts (luhn/verhoeff/damm/mod97).ac_checksum_validate/ac_checksum_digit.CommandSpecs under Data.Tests / docs
test/unit_test/headless/test_checksum_batch.py— 9 headless tests (Luhn 79927398713 + card, Verhoeff/Damm transposition catching, MOD 97-10 IBAN vector + 2-digit append, round-trips, unknown-scheme error + wiring + facade).v115_features_doc.rst+ toctrees; 3 WHATS_NEW changelog entries.