localize input mfxFrameSurface1* for scale_qsv#38
Open
YaboWei wants to merge 2 commits intoIntel-FFmpeg-Plugin:intel_ffmpeg-3.4.1from
Open
localize input mfxFrameSurface1* for scale_qsv#38YaboWei wants to merge 2 commits intoIntel-FFmpeg-Plugin:intel_ffmpeg-3.4.1from
YaboWei wants to merge 2 commits intoIntel-FFmpeg-Plugin:intel_ffmpeg-3.4.1from
Conversation
|
Patch looks good expect need a better commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If scale_qsv + enc and ONLY enc called by different thread, ONLY enc may got a Locked mfxFrameSurface1(
Intel_FFmpeg_plugins/libavcodec/qsvenc.c
Line 1120 in bd1a484
Intel_FFmpeg_plugins/libavutil/hwcontext_qsv.c
Line 379 in bd1a484
If scale_qsv also localize input surf like enc, ONLY enc would never got a Locked mfxFrameSurface1, it's OK.