Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the pre-commit hook configuration for mkl-service to align with other mkl packages, adding new security and linting checks. It also fixes shell quoting issues across CI workflows identified by the newly added shellcheck enforcement.
Changes:
- Adds new pre-commit hooks:
check-added-large-files,no-commit-to-branch,check-illegal-windows-names,gitleaks(secret scanning), andactionlint(GitHub Actions linting). - Fixes shell quoting issues in CI workflows (
conda-package.yml,build-with-clang.yml) to correctly handle paths with spaces and use bash arrays for multi-word arguments, resolvingshellcheckwarnings. - Updates
.git-blame-ignore-revsto record this commit forgit blamepurposes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.pre-commit-config.yaml |
Adds five new hooks (large files, branch protection, Windows name checks, gitleaks, actionlint); introduces a duplicate check-case-conflict entry |
.github/workflows/pre-commit.yml |
Fixes shell quoting; contains a mismatch between the clang-format version installed and the symlink target |
.github/workflows/conda-package.yml |
Converts unquoted shell variables to properly quoted strings and bash arrays; adds shell: cmd to a Windows step; expands inline channel lists |
.github/workflows/build-with-clang.yml |
Adds shell quoting around $CMPLR_ROOT usages |
.git-blame-ignore-revs |
Records this commit SHA to exclude it from git blame output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e3bb62f to
7dcf632
Compare
also removes redundant line/copy-paste error from pre-commit config
7dcf632 to
bf96b24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the number of pre-commit checks to align mkl-service with the other mkl packages,