Align conda-forge recipe with normal recipe#285
Open
ndgrigorian wants to merge 4 commits intomasterfrom
Open
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
ndgrigorian
force-pushed
the
update-conda-forge-recipe
branch
from
d5aa34a to
81591cb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the conda-forge recipe (conda-recipe-cf) metadata and CI behavior closer to the primary conda recipe (conda-recipe) to standardize versioning/build metadata and dependencies.
Changes:
- Update
conda-recipe-cf/meta.yamlto useGIT_DESCRIBE_TAG/GIT_DESCRIBE_NUMBER, addscript_env, and align several build/host/run requirements. - Adjust recipe metadata text (summary/description) and simplify import checks under
test:. - Remove the explicit MSVC setup step from the Windows conda-package workflows.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
conda-recipe-cf/meta.yaml |
Switch to git-describe versioning/build numbering; add build env forwarding and align dependency list/metadata. |
.github/workflows/conda-package.yml |
Remove MSVC environment setup step before Windows conda build. |
.github/workflows/conda-package-cf.yml |
Remove MSVC environment setup step before Windows conda build (NumPy 2.x matrix). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to align the
meta.yamlinconda-recipe-cfwithconda-recipeAlso removes MSVC setup step, instead using conda build configs to set VS version. This exposed mistake in conda build config, which was set to vs2017