Skip to content

Benjaminmichaelis/fix streaming textdone events#1165

Draft
BenjaminMichaelis wants to merge 5 commits into
mainfrom
benjaminmichaelis/fix-streaming-textdone-events
Draft

Benjaminmichaelis/fix streaming textdone events#1165
BenjaminMichaelis wants to merge 5 commits into
mainfrom
benjaminmichaelis/fix-streaming-textdone-events

Conversation

@BenjaminMichaelis

Copy link
Copy Markdown
Member

Description

Describe your changes here.

Fixes #Issue_Number (if available)

Ensure that your pull request has followed all the steps below:

  • Code compilation
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Propagate stream failure categories (error, failed, incomplete) via
ChatBackendUnavailableException.ErrorCode and return specific message/code
in both JSON and SSE error responses.
Adjust LocalChatService to use named innerException argument after
ChatBackendUnavailableException constructor expansion.
Log streaming error, failed, and incomplete terminal updates with
response id, status, error code/message, and incomplete reason to
make production failures diagnosable before merge.
Capture the recent streaming update type sequence in terminal stream
failure logs (error, failed, incomplete) to improve diagnosis of
opaque upstream stream errors.
@BenjaminMichaelis BenjaminMichaelis force-pushed the benjaminmichaelis/fix-streaming-textdone-events branch from 485e433 to 5b05fa1 Compare June 1, 2026 23:55
…ming responses

Exception details are now only in server logs (already logged via LogChatStreamErrorBeforeResponseStarted
and LogChatStreamErrorMidStream). The errorCode from ChatBackendUnavailableException is still
forwarded as it is a controlled application-level value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant