Refactor python package: unify f32/f64 implementations & zero copy views where possible #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1th0utnam3
force-pushed
the
refactor_python
branch
from
63aef9e to
dba1393
Compare
w1th0utnam3
force-pushed
the
refactor_python
branch
from
edb3ef0 to
fb7eedb
Compare
w1th0utnam3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Python bindings of splashsurf and unifies all separate implementations for f32 and f64 data types. Additionally all inputs/outputs and properties across the bindings now use views without copies where possible. This includes attributes such as
mesh.verticesetc.