[Refactor] Move _init_load_spec from model __init__ to TrainEngine.build_model#1676
Open
HIT-cwh wants to merge 1 commit intoInternLM:mainfrom
Open
[Refactor] Move _init_load_spec from model __init__ to TrainEngine.build_model#1676HIT-cwh wants to merge 1 commit intoInternLM:mainfrom
HIT-cwh wants to merge 1 commit intoInternLM:mainfrom
Conversation
…ild_model Since build_model constructs the model on meta device, _init_load_spec needs to run after model construction rather than inside __init__. This moves the call to build_model where it recursively initializes load specs for all BaseModel submodules after meta device construction and before fully_shard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.