Refactor install script for better temp handling#35
Open
perturbing wants to merge 2 commits into
Open
Conversation
perturbing
force-pushed
the
perturbing-patch-4
branch
5 times, most recently
from
54bdbee to
3a98ba4
Compare
There was a problem hiding this comment.
Pull request overview
This PR improves the macOS cc-sign installer script by using a per-run temporary directory and safer download options, and it reduces Nix/Hydra evaluation scope to avoid CI failures.
Changes:
- Refactor
install-cc-sign-mac-os.shto usemktemp -d+trapcleanup, and hardencurlusage. - Restrict flake
systemsto Linux-only evaluation. - Disable MinGW-w64 Hydra jobs in the Nix project configuration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
nix/project.nix |
Disables MinGW-w64 Hydra jobs via includeMingwW64HydraJobs = false. |
install-cc-sign-mac-os.sh |
Uses a dedicated temp directory with cleanup trap; hardens download/unzip flow. |
flake.nix |
Limits evaluated systems to x86_64-linux, disabling Darwin (and other) systems. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
perturbing
force-pushed
the
perturbing-patch-4
branch
3 times, most recently
from
52bc6ff to
4a1144b
Compare
perturbing
force-pushed
the
perturbing-patch-4
branch
from
4a1144b to
9070322
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens the usage of the temp file in the Darwin install scripts.
Additionally, it disables the Darwin and Windows CI as Hydra CI crashes on it (for some reason the build plan fails). A solution is clearing the cache on Hydra for the failing build (to force evaluation), but this is cumbersome to do again and again.