Fix in-app message dark mode pinning on Android 13+ (#1056)#1057
Open
AndrazP wants to merge 1 commit into
Open
Fix in-app message dark mode pinning on Android 13+ (#1056)#1057AndrazP wants to merge 1 commit into
AndrazP wants to merge 1 commit into
Conversation
In-app HTML messages always rendered the prefers-color-scheme: dark variant regardless of the system theme on API 33+. Two fixes: - Switch DialogFragment style from Theme.AppCompat.NoActionBar (a dark theme: extends Theme.AppCompat, not Theme.AppCompat.Light) to Theme.AppCompat.DayNight.NoActionBar, so isLightTheme tracks the system mode. - Build the WebView with the dialog's themed context instead of Fragment.getContext(), which returns the host activity context. On API 33+ WebView derives prefers-color-scheme from the hosting theme's isLightTheme attribute, so the DayNight fix only takes effect when the WebView is constructed under the dialog context. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-app HTML messages always rendered the prefers-color-scheme: dark variant regardless of the system theme on API 33+. Two fixes:
Switch DialogFragment style from Theme.AppCompat.NoActionBar (a dark theme: extends Theme.AppCompat, not Theme.AppCompat.Light) to Theme.AppCompat.DayNight.NoActionBar, so isLightTheme tracks the system mode.
Build the WebView with the dialog's themed context instead of Fragment.getContext(), which returns the host activity context. On API 33+ WebView derives prefers-color-scheme from the hosting theme's isLightTheme attribute, so the DayNight fix only takes effect when the WebView is constructed under the dialog context.
🔹 Jira Ticket(s) if any
/
✏️ Description
See #1056