Start adding localization#2
Conversation
|
If it does work, I will finish the localisations. |
|
Thanks for the contribution Aaron! Unfortunately, I have very limited time because I'm finishing my master thesis this month. Could you try to setup your own bot on own server and test it? I've added a quick guide how to do it in the readme. Overall, your proposed solution has a lot defects, namely unused variables, wrong formatting etc. but more importantly I doubt it is able to handle multi-language load. The bot may listen on multiple servers that have to be independent - from the language perspective. Side note: The Discord.NET library that I depend on released its 2nd version a few months ago. I still did not upgrade thought. I would do some research how does other bots handle localisation, maybe they did add some native support or somebody created an extension for it. |
I didn't actually need a localization service. It was built in code generation automatically. The strings can be retrieved from the resources file automatically and are dependent on the supplied thread.
|
I managed to get it to work on my server properly. I fixed things up. I decided against a localization service because it was unnecessary. That functionality was built into C# projects by default. Updating to the newest version of Discord.NET is going to be a pain, if trying to update the clean module and then reverting back to a prior version were an indicator. There's more places where the summary needs to be changed to a key name however. |
Still have more to go.
|
I really appreciate your effort but can you revert cosmetic changes, please? It is really painful to do a code review that literally changes all files. For instance adding/removing private access modifier, change from explicit type to var vice versa, adding/removing brackets, adding/removing white spaces, newline at the end of file, converting standard methods to arrow functions etc. |
|
I will do my best to try to undo my cosmetic changes. |
…riable is not found. Also try to create a nice text file for letting users know to contribute more languages.
Excuse me, but would you test to see if what I have localized so far works.