Update versioning check scripts #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area
force-pushed
the
maint/versioning-check
branch
from
d94830d to
a868590
Compare
kronosapiens
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the pieces of cruft we hadn't cleaned up from the Arbitrum release was that we hadn't actually released
imwsson GitHub, which meant that our versioning check was doing so againsthmwss. The two main consequences of that were:imwsswere passed if the version was bumped inhmwsstruffletohardhatAs a result of 1, we missed a required version bump in #1259, but it doesn't appear any others.
This PR intends to fix these issues. Arguably the most meaningful change is an indirect result of the release though, which is how I'm treating upgrades in tests. For historical behaviour, I'm assuming that doing an upgrade from e.g. 12 to 13 to 16 is sufficient to test, rather than having to deploy 14 and 15 as well. This seems to work for all of our tests so far; it will need to be revisited if that assumption no longer holds.