Skip to content

add sliding_window_maxima#126

Closed
nsajko wants to merge 14 commits intoJuliaCollections:masterfrom
nsajko:sliding_window_maxima
Closed

add sliding_window_maxima#126
nsajko wants to merge 14 commits intoJuliaCollections:masterfrom
nsajko:sliding_window_maxima

Conversation

@nsajko
Copy link
Copy Markdown
Member

@nsajko nsajko commented Jul 9, 2025

Feature addition: add iterator whose elements are maxima of a sliding window over an original iterator.

Feature addition: add iterator whose elements are maxima of a sliding
window over an original iterator.
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2025

Codecov Report

❌ Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.96%. Comparing base (568d12c) to head (b589762).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/IterTools.jl 98.64% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   90.72%   91.96%   +1.23%     
==========================================
  Files           1        1              
  Lines         399      473      +74     
==========================================
+ Hits          362      435      +73     
- Misses         37       38       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oxinabox
Copy link
Copy Markdown
Member

oxinabox commented Jul 9, 2025

why does this have some very aggressive compiler directives thoughout it?

these are going to require careful hand checking.
The compiler can normally work things out.

@nsajko

This comment was marked as outdated.

Comment thread src/IterTools.jl Outdated
@nsajko
Copy link
Copy Markdown
Member Author

nsajko commented Aug 9, 2025

bump

@nsajko
Copy link
Copy Markdown
Member Author

nsajko commented Aug 22, 2025

bump

@oxinabox
Copy link
Copy Markdown
Member

sorry, its just i am not sure if this belongs in this package or not.
It's a very intricate function.

@nsajko nsajko closed this Mar 4, 2026
@nsajko nsajko deleted the sliding_window_maxima branch March 4, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants