Remove allocations of nested Jacobians of StaticArrays#810
Open
albert-de-montserrat wants to merge 1 commit into
Open
Remove allocations of nested Jacobians of StaticArrays#810albert-de-montserrat wants to merge 1 commit into
albert-de-montserrat wants to merge 1 commit into
Conversation
Refactor gradient and jacobian functions to use direct function calls instead of static_dual_eval.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #810 +/- ##
==========================================
- Coverage 90.75% 90.74% -0.01%
==========================================
Files 11 11
Lines 1071 1070 -1
==========================================
- Hits 972 971 -1
Misses 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
devmotion
reviewed
Jun 1, 2026
Member
devmotion
left a comment
There was a problem hiding this comment.
Can you add a test that fails on master but passes with these changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses and fixes the issue raised in #798.
The same MWE now yields:
Looks like the compiler was giving up to inline
static_dual_eval(T, f, x)in this case. Manual inlining seems to solve the problem.