Fix TestEnv for subpackages: precompile only the new test Project#90
Merged
Fix TestEnv for subpackages: precompile only the new test Project#90
Conversation
Member
Author
|
FYI the definitely seems like a flakey unrelated failure |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 78.17% 78.27% +0.09%
==========================================
Files 34 34
Lines 921 925 +4
==========================================
+ Hits 720 724 +4
Misses 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
🤔 the 1.9 / 1.10 test failures seem real: but weirdly the tests all pass for me locally, on julia 1.9, 1.10, and 1.11 on both macos and linux... 🤔 any ideas? JULIA_PKG_SERVER_REGISTRY_PREFERENCE=eager julia +1.10 --proj --startup=no -e 'using Pkg; Pkg.test()'
...
Test Summary: | Pass Total Time
TestEnv.jl | 16 16 6.1s
Testing TestEnv tests passed |
Member
Author
|
Gonna try checking if CI is just broken due to something transient in the Pkg registry or something like that, by opening this PR: #91. |
|
Local reproduction of the problem: |
Drvi
approved these changes
Feb 10, 2026
Drvi
added a commit
that referenced
this pull request
Feb 20, 2026
Fix TestEnv for subpackages: precompile only the new test Project, take 2 Like #90, but uses Pkg._auto_precompile instead of Pkg.precompile to respect the JULIA_PKG_PRECOMPILE_AUTO env var.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89.
Woohoo! :) It seems to work now! :)
@davidanthoff: This should also make testing subpackages faster in VSCode as well, not just for ReTestItems.
I'm happy to clone 1.9 into a 1.10 directory, and make this change there, but it doesn't seem to hurt anything on older versions so it seems like we can keep things as-is?