Do not set time rates when better time warp or time control is installed#311
Merged
PhineasFreak merged 6 commits intoKSP-RO:masterfrom May 2, 2026
Merged
Do not set time rates when better time warp or time control is installed#311PhineasFreak merged 6 commits intoKSP-RO:masterfrom
PhineasFreak merged 6 commits intoKSP-RO:masterfrom
Conversation
|
I think it would be better if the RSS warp rates were moved outside the base settings file and set as a compatibility patch: There is also a minor logging bug where RSS will indicate that the warp rates are set even when they are not: RealSolarSystem/Source/TimeWarpFixer.cs Lines 31 to 41 in cadfcc9 Debug.Log() should be inside the "twNode" null check block. |
Author
|
Done. |
PhineasFreak
reviewed
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fix #305
I have no idea if this is the correct syntax for MM, please correct me if wrong.