Skip to content

Do not set time rates when better time warp or time control is installed#311

Merged
PhineasFreak merged 6 commits intoKSP-RO:masterfrom
Clayell:time
May 2, 2026
Merged

Do not set time rates when better time warp or time control is installed#311
PhineasFreak merged 6 commits intoKSP-RO:masterfrom
Clayell:time

Conversation

@Clayell
Copy link
Copy Markdown

@Clayell Clayell commented Jan 16, 2025

Hopefully fix #305

I have no idea if this is the correct syntax for MM, please correct me if wrong.

@PhineasFreak
Copy link
Copy Markdown

I think it would be better if the RSS warp rates were moved outside the base settings file and set as a compatibility patch:

[Compatibility/BetterTimeWarp.cfg]

@REALSOLARSYSTEM:NEEDS[!BetterTimeWarpCont&!TimeControl]
{
    %timeWarpRates
    {
        %rate1 = 10
        %rate2 = 100
        %rate3 = 1000
        %rate4 = 10000
        %rate5 = 100000
        %rate6 = 1000000
        %rate7 = 6000000
    }
}

There is also a minor logging bug where RSS will indicate that the warp rates are set even when they are not:

Debug.Log("[RealSolarSystem] Setting TimeWarp rates...");
if (twNode != null)
{
for (int i = 1; i < 8; i++)
{
if (twNode.HasValue("rate" + i))
if (float.TryParse(twNode.GetValue("rate" + i), out float ftmp))
TimeWarp.fetch.warpRates[i] = ftmp;
}
}

Debug.Log() should be inside the "twNode" null check block.

@Clayell
Copy link
Copy Markdown
Author

Clayell commented May 2, 2026

Done.

Comment thread GameData/RealSolarSystem/Compatibility/TimeWarp.cfg Outdated
@PhineasFreak PhineasFreak merged commit 4cba468 into KSP-RO:master May 2, 2026
3 checks passed
@Clayell Clayell deleted the time branch May 2, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RSS overrides timeWarpRates from BetterTimeWarp at startup

2 participants