Skip to content

fix(gdc): add Unicode box drawing exception and bump to v1.2.0#106

Merged
KemingHe merged 3 commits into
mainfrom
fix/gdc-box-drawing-exception/KemingHe
Jun 1, 2026
Merged

fix(gdc): add Unicode box drawing exception and bump to v1.2.0#106
KemingHe merged 3 commits into
mainfrom
fix/gdc-box-drawing-exception/KemingHe

Conversation

@KemingHe
Copy link
Copy Markdown
Owner

@KemingHe KemingHe commented Jun 1, 2026

Resolve GDC Characters constraint ambiguity for tree-style directory rendering used by doc-generation skills, and bump documentation-review metadata to credit external contributor.

closes #99
closes #105

Changes

  • Add Unicode box drawing characters as named exception in GDC Characters constraint alongside existing exception
  • Bump canonical GDC from v1.1.1 to v1.2.0
  • Propagate updated GDC section across all 13 embedded copies (whole-section replace)
  • Bump documentation-review skill from 2.0.0 to 2.1.0 for checklist logic change introduced in PR fix(gdc): clarify prose wrapping rule #104
  • Add contributors field to documentation-review frontmatter crediting puneetdixit200
  • Update Characters checklist rows in documentation-review SKILL.md and README.md

Impact

  • Doc-generation skills no longer produce ambiguous constraint violations when rendering tree --dirsfirst output
  • Completes the GDC fix cycle started in PR fix(gdc): clarify prose wrapping rule #104 (prose wrapping) - both known constraint bugs now resolved

Notes

  • 14 files changed across 13 skills; all diffs are mechanical replacements except documentation-review which also gets metadata updates
  • After merge, common-devx enters maintenance-only mode through mid-July 2026 (no new features, no external PR reviews)

KemingHe added 3 commits June 1, 2026 13:39
CHANGES
- Add box drawing characters as named exception for tree-style directory rendering
- Pluralize "Exception" to "Exceptions" to accommodate multiple entries
- Bump canonical GDC from v1.1.1 to v1.2.0

SCOPE
- Canonical source: skill-creation/assets/general-doc-constraints.md
- Host skill embed: skill-creation/SKILL.md
- Remaining 11 embeds propagated in follow-up commit
closes #99

CHANGES
- Update Characters constraint and version footer in 11 remaining SKILL.md files
- All 13 GDC embed locations now consistent at v1.2.0
closes #105

CHANGES
- Bump version from 2.0.0 to 2.1.0 for checklist logic change in PR #104
- Add contributors field crediting puneetdixit200
- Update Characters checklist row to reflect GDC v1.2.0 box drawing exception
@KemingHe KemingHe self-assigned this Jun 1, 2026
Copilot AI review requested due to automatic review settings June 1, 2026 17:48
@KemingHe KemingHe added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 1, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the General Doc Constraints (GDC) Characters rule to explicitly permit Unicode box drawing characters for tree-style directory rendering, bumps the canonical GDC to v1.2.0, and propagates the change across all 13 embedded copies. Also bumps the documentation-review skill to v2.1.0 and credits external contributor puneetdixit200.

Changes:

  • Add Unicode box drawing characters as a named exception in the GDC Characters constraint and bump GDC from v1.1.1 to v1.2.0 across the canonical asset and all embedded SKILL.md copies
  • Update the documentation-review checklist rows (SKILL.md and README.md) to reflect the new exception
  • Bump documentation-review skill from 2.0.0 to 2.1.0 and add contributors: [puneetdixit200] in frontmatter

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.agents/skills/skill-creation/assets/general-doc-constraints.md Canonical GDC: add box drawing exception, bump to v1.2.0
.agents/skills/skill-creation/SKILL.md Embedded GDC update
.agents/skills/readme-creation/SKILL.md Embedded GDC update
.agents/skills/pull-merge-request-creation/SKILL.md Embedded GDC update
.agents/skills/next-session-handoff/SKILL.md Embedded GDC update
.agents/skills/meeting-memo-creation/SKILL.md Embedded GDC update
.agents/skills/meeting-agenda-creation/SKILL.md Embedded GDC update
.agents/skills/living-design-documents/SKILL.md Embedded GDC update
.agents/skills/issue-creation/SKILL.md Embedded GDC update
.agents/skills/dot-gitlab-sync/SKILL.md Embedded GDC update
.agents/skills/documentation-review/SKILL.md Embedded GDC update, version bump to 2.1.0, contributor metadata, checklist row update
.agents/skills/documentation-review/README.md Checklist row updated for new exception
.agents/skills/contacts-management/SKILL.md Embedded GDC update
.agents/skills/commit-message-creation/SKILL.md Embedded GDC update

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Owner Author

@KemingHe KemingHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionally self-reviewed: lgtm

@KemingHe KemingHe merged commit 0200c9c into main Jun 1, 2026
2 checks passed
@KemingHe KemingHe deleted the fix/gdc-box-drawing-exception/KemingHe branch June 1, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

2 participants