fix(gdc): add Unicode box drawing exception and bump to v1.2.0#106
Merged
Conversation
CHANGES - Add box drawing characters as named exception for tree-style directory rendering - Pluralize "Exception" to "Exceptions" to accommodate multiple entries - Bump canonical GDC from v1.1.1 to v1.2.0 SCOPE - Canonical source: skill-creation/assets/general-doc-constraints.md - Host skill embed: skill-creation/SKILL.md - Remaining 11 embeds propagated in follow-up commit
closes #99 CHANGES - Update Characters constraint and version footer in 11 remaining SKILL.md files - All 13 GDC embed locations now consistent at v1.2.0
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the General Doc Constraints (GDC) Characters rule to explicitly permit Unicode box drawing characters for tree-style directory rendering, bumps the canonical GDC to v1.2.0, and propagates the change across all 13 embedded copies. Also bumps the documentation-review skill to v2.1.0 and credits external contributor puneetdixit200.
Changes:
- Add Unicode box drawing characters as a named exception in the GDC Characters constraint and bump GDC from v1.1.1 to v1.2.0 across the canonical asset and all embedded SKILL.md copies
- Update the documentation-review checklist rows (SKILL.md and README.md) to reflect the new exception
- Bump documentation-review skill from 2.0.0 to 2.1.0 and add
contributors: [puneetdixit200]in frontmatter
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .agents/skills/skill-creation/assets/general-doc-constraints.md | Canonical GDC: add box drawing exception, bump to v1.2.0 |
| .agents/skills/skill-creation/SKILL.md | Embedded GDC update |
| .agents/skills/readme-creation/SKILL.md | Embedded GDC update |
| .agents/skills/pull-merge-request-creation/SKILL.md | Embedded GDC update |
| .agents/skills/next-session-handoff/SKILL.md | Embedded GDC update |
| .agents/skills/meeting-memo-creation/SKILL.md | Embedded GDC update |
| .agents/skills/meeting-agenda-creation/SKILL.md | Embedded GDC update |
| .agents/skills/living-design-documents/SKILL.md | Embedded GDC update |
| .agents/skills/issue-creation/SKILL.md | Embedded GDC update |
| .agents/skills/dot-gitlab-sync/SKILL.md | Embedded GDC update |
| .agents/skills/documentation-review/SKILL.md | Embedded GDC update, version bump to 2.1.0, contributor metadata, checklist row update |
| .agents/skills/documentation-review/README.md | Checklist row updated for new exception |
| .agents/skills/contacts-management/SKILL.md | Embedded GDC update |
| .agents/skills/commit-message-creation/SKILL.md | Embedded GDC update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KemingHe
commented
Jun 1, 2026
Owner
Author
KemingHe
left a comment
There was a problem hiding this comment.
additionally self-reviewed: lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve GDC Characters constraint ambiguity for tree-style directory rendering used by doc-generation skills, and bump documentation-review metadata to credit external contributor.
closes #99
closes #105
Changes
↑exceptioncontributorsfield to documentation-review frontmatter crediting puneetdixit200Impact
tree --dirsfirstoutputNotes