Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -352,3 +352,4 @@ healthchecksdb
logs
*.pem
*.crt
.claude/settings.local.json
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
- 1.2.3
- Fixed Sans Being passed through Extensions Data, Google does not like this.
- 1.2.2
- Fixed Sync Issues at CA Level, was ignoring and always syncing at pool level
- 1.2.1
- Doc Updates
- 1.2.0
- Added Enable Flag
- Dual Build Support
Expand Down
14 changes: 8 additions & 6 deletions GCPCAS/Client/CreateCertificateRequestBuilder.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright © 2025 Keyfactor
Copyright � 2025 Keyfactor

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -85,12 +85,14 @@ public ICreateCertificateRequestBuilder WithEnrollmentProductInfo(EnrollmentProd
string base64Value = param.Value;

_logger.LogTrace($"Loggin oid and value {oid} {base64Value}");

var extension = CreateX509Extension(oid, base64Value);
if (extension != null)
if (oid != "2.5.29.17") //can't send Sans as an extension to google, they do not like this and you will get an error
{
_logger.LogTrace($"Adding Extension");
_additionalExtensions.Add(extension);
var extension = CreateX509Extension(oid, base64Value);
if (extension != null)
{
_logger.LogTrace($"Adding Extension");
_additionalExtensions.Add(extension);
}
}
}
}
Expand Down
Loading
Loading