prevent stack overflow in check_name_matches_filter_environment_var#1912
Merged
charles-lunarg merged 1 commit intoJun 2, 2026
Merged
Conversation
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
charles-lunarg
approved these changes
Jun 2, 2026
Collaborator
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
This is a decent fix, but reveals a bigger problem - loader_icd_scan calls check_name_matches_filter_environment_var but gives it unbounded length strings.
Trying to support both in the same function is difficult, so I would rather approve this PR and create a followup issue to track it.
|
CI Vulkan-Loader build queued with queue ID 754244. |
|
CI Vulkan-Loader build # 3500 running. |
|
CI Vulkan-Loader build # 3500 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_name_matches_filter_environment_var lowercases its name argument into a fixed lower_name[VK_MAX_EXTENSION_NAME_SIZE] buffer indexed by strlen(name). Layer names are capped to that size when the manifest is parsed, but loader_icd_scan hands the ICD manifest filename to the driver select/disable filters, and a filename carries no such cap, so a long one writes past lower_name. Clamp the length the same way settings.c already does for layer names.