improve useability#72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kitrt_code PR Notes
Summary
This PR addresses the KiT-RT-side accessibility and usability gaps from
kitrt_accessibility_usability_plan.mdin the nested checkout at/home/8v5/projects/CharmKiT/kitrt_code.Verified Gaps And Changes
CMakeLists.txtreports1.2.0, whiledoc/conf.pystill reportedv0.1. Updated Sphinxversionandreleaseto1.2.0and enabled version display..readthedocs.ymlstill used the legacy Python 3.7 selector. Updated it to the v2 build image/tool format with Python 3.11.Start heresection that explainskitrt_codeversus CharmKiT, documents a ten-minute CPU smoke test, points sweep/SLURM users to CharmKiT, and points stuck users to troubleshooting.doc/status.rst,doc/getting_started.rst, anddoc/troubleshooting.rst, and linked them fromdoc/index.rst.examples/configs/smoke_test.cfg,doc/tutorials/smoke_test.rst, andtools/check_smoke_output.py, plus an.gitignoreexception so the new config appears in the PR.doc/installation.rstwith the smoke command and checker.0.1.0. Added a1.2.0section with the release artifact checklist and current commit-citation guidance until official releases are published.tools/singularity/build_container.shto useKITRT_CONTAINER_RUNTIME, auto-detect Apptainer before Singularity, and keep the existing CPU/CUDA/ROCm modes.Primary Files
.gitignore.readthedocs.ymlREADME.mddoc/conf.pydoc/index.rstdoc/installation.rstdoc/release.rstdoc/status.rstdoc/getting_started.rstdoc/tutorials/smoke_test.rstdoc/troubleshooting.rstexamples/configs/smoke_test.cfgtools/check_smoke_output.pytools/singularity/build_container.shVerification
python3 -m py_compile tools/check_smoke_output.pysingularity exec tools/singularity/kit_rt.sif ./build_singularity/KiT-RT examples/configs/smoke_test.cfgpython3 tools/check_smoke_output.py examples/result/smoke_test->PASS output_files=1 csv_logs=1 mass=0.9439827git diff --checkNot Included