Skip to content

Fix typo and NO_COLOR environment variable handling #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
assisted-by-ai wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Fix typo and NO_COLOR environment variable handling #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions usr/lib/python3/dist-packages/unicode_show/tests/unicode_show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def test_clean_ascii(self) -> None:

test_string: str = (
" !\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]"
+ "^_`abcdefghjiklmnopqrstuvwxyz{|}~\n"
+ "^_`abcdefghijklmnopqrstuvwxyz{|}~\n"
Copy link
Copy Markdown
Contributor

@ArrayBolt3 ArrayBolt3 Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted.

)
self._test_stdin(
main_func=unicode_show_main,
Expand Down Expand Up @@ -480,7 +480,7 @@ def test_pty_color(self) -> None:
self._test_stdin_pty(
main_func=unicode_show_main,
argv0=self.argv0,
stdout_string=expect_string_color,
stdout_string=expect_string_nocolor,
Copy link
Copy Markdown
Contributor

@ArrayBolt3 ArrayBolt3 Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was removed in an earlier commit.

exit_code=1,
args=[],
stdin_string=test_string,
Expand Down
2 changes: 1 addition & 1 deletion usr/lib/python3/dist-packages/unicode_show/unicode_show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def main() -> int:
global USE_COLOR
USE_COLOR = (
not os.getenv("NOCOLOR")
and os.getenv("NO_COLOR") != "1"
and os.getenv("NO_COLOR") is None
Copy link
Copy Markdown
Contributor

@ArrayBolt3 ArrayBolt3 Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in a different PR (and this is the wrong way to fix it).

and os.getenv("TERM") != "dumb"
and sys.stdout.isatty()
)
Expand Down
Loading