Improve stdin/stdout encoding configuration for robust text handling#35
Open
assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
Open
Conversation
…epth sanitize_string.py was missing two defense-in-depth measures that all st* tools (stcat, stcatn, stecho, stprint, stsponge, sttee) already had: 1. stdin used errors="ignore" without explicit encoding, silently dropping invalid bytes. Changed to encoding="utf-8", errors="replace" to match st* tools — invalid bytes become U+FFFD then get replaced with '_' by stdisplay, making tampering visible. 2. stdout was never reconfigured to ASCII encoding. Added encoding="ascii", errors="replace" to match st* tools — provides a safety net if a non-ASCII character ever survives the sanitization pipeline. https://claude.ai/code/session_01CKA1A2XSprq49uNtGiMBxW
Contributor
|
Researched, decided the changes were good, accepted.in ArrayBolt3@47c6252. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced the stdin and stdout stream configuration to explicitly specify encoding, error handling, and newline behavior, improving robustness when processing untrusted input and ensuring consistent output formatting.
Key Changes
Implementation Details
These changes ensure:
\n)https://claude.ai/code/session_01CKA1A2XSprq49uNtGiMBxW