Fix sdwdate status icon display for unknown clients#5
Open
assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
Open
Fix sdwdate status icon display for unknown clients#5assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
Conversation
When a client connects and sets its name but hasn't yet reported its sdwdate status, regen_menu() would skip the client entirely due to the `else: continue` branch when sdwdate_status is UNKNOWN and tor_status is not STOPPED/DISABLED. This caused only "Exit" to appear in the right-click menu during the timing window between client name registration and the first status update. Instead of skipping unknown-status clients, treat them as BUSY (showing the waiting icon) so the full menu is always available. https://claude.ai/code/session_01JuseGKPwFHpNLEXj3Fzp8L
Contributor
|
Will merge this. The implementation given here is a bit inefficient, and also may show clients that aren't fully "ready" (i.e. ones that have not specified a non-UNKNOWN Tor or sdwdate status), but the general idea makes sense, and I was able to make an implementation that I believe is good. |
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modified the client icon selection logic in the menu regeneration function to properly handle clients with unknown sdwdate status by displaying a BUSY icon instead of skipping them entirely.
Key Changes
elif client.sdwdate_status != SdwdateStatus.UNKNOWNto anelseblock that handles all non-Tor status casesSdwdateStatus.UNKNOWNby mapping it toSdwdateStatus.BUSYfor icon display purposescontinuestatement that was skipping clients with unknown sdwdate status, ensuring they now appear in the menu with an appropriate iconImplementation Details
https://claude.ai/code/session_01JuseGKPwFHpNLEXj3Fzp8L