feat(cloud-agent-next): disable question tool for cloud-agent sessions#1023
Open
feat(cloud-agent-next): disable question tool for cloud-agent sessions#1023
Conversation
Temporarily disable the question tool for cloud-agent sessions. If a user doesn't answer a question before the sandbox expires, the Kilo server rejects the late reply and the UI ends up in a broken state. Until that is resolved, deny the question tool for cloud-agent sessions.
The test used an exact string match but the startup command now includes WRAPPER_LOG_PATH with a Date.now() timestamp. Use a regex match instead so the assertion is deterministic.
eshurakov
force-pushed
the
eshurakov/cloud-agent-disable-question-tool
branch
from
e04a1fd to
d2e3cf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporarily disable the question tool for
cloud-agentandapp-buildersessions. If a user doesn't answer a question before the sandbox expires, the Kilo server rejects the late reply and the UI ends up in a broken state. Until that underlying issue is resolved, this change addsquestion: 'deny'to the permission config for these sessions, matching the behavior already in place forslack,webhook, and other non-interactive platforms.Also fixes a pre-existing broken test in
wrapper-client.test.tswhere the shell-quote assertion didn't account for theWRAPPER_LOG_PATHenv var added to the wrapper startup command.Verification
pnpm run test— 650 passed, 0 failurescloud-agentandapp-buildernow getquestion:deny, onlyundefined(no platform) remains interactiveVisual Changes
N/A
Reviewer Notes
isInteractivecondition insession-service.ts:581to!createdOnPlatform— only sessions with no platform set retain the question tool.cloud-agentorapp-buildersessions.expect.stringMatching(...)with a regex to handle the non-deterministicDate.now()timestamp inWRAPPER_LOG_PATH.