Skip to content

refactor(kiloclaw): rename onChannelsChanged/dirtyChannels to onSecretsChanged/dirtySecrets#1046

Merged
St0rmz1 merged 1 commit intomainfrom
cleanup/rename-channels-to-secrets-props
Mar 11, 2026
Merged

refactor(kiloclaw): rename onChannelsChanged/dirtyChannels to onSecretsChanged/dirtySecrets#1046
St0rmz1 merged 1 commit intomainfrom
cleanup/rename-channels-to-secrets-props

Conversation

@St0rmz1
Copy link
Contributor

@St0rmz1 St0rmz1 commented Mar 11, 2026

Summary

Renames the onChannelsChanged/dirtyChannels prop and state pair to onSecretsChanged/dirtySecrets across ClawDashboard.tsx and SettingsTab.tsx. Also renames the callback parameter from channelType to entryId to match what it actually tracks (catalog entry IDs, not channel types).

This fixes a naming mismatch introduced during the catalog migration — SettingsTab was receiving onChannelsChanged from its parent but passing it as onSecretsChanged to SecretEntrySection. P1 cleanup item from the secret-catalog-registry plan.

Verification

  • TypeScript typecheck passes (no type changes, just renames)
  • Prettier formatting passes
  • Grep confirms zero remaining references to onChannelsChanged or dirtyChannels in src/

Visual Changes

N/A

Reviewer Notes

  • 2 files, 12 lines changed — mechanical rename, no logic changes
  • The UI-visible "Channels" heading and DetailTile label are intentionally unchanged. Those describe the current secret category shown to users and will be revisited when non-channel categories (tools, providers) are added
  • SecretEntrySection already used onSecretsChanged as its prop name — this rename just makes the parent chain consistent

@kilo-code-bot
Copy link
Contributor

kilo-code-bot bot commented Mar 11, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • src/app/(app)/claw/components/ClawDashboard.tsx
  • src/app/(app)/claw/components/SettingsTab.tsx

Reviewed by gpt-5.4-20260305 · 171,147 tokens

@St0rmz1 St0rmz1 changed the title refactor(kiloclaw): rename onChannelsChanged/dirtyChannels to onSecre… refactor(kiloclaw): rename onChannelsChanged/dirtyChannels to onSecretsChanged/dirtySecrets Mar 11, 2026
@St0rmz1 St0rmz1 linked an issue Mar 11, 2026 that may be closed by this pull request
@St0rmz1 St0rmz1 merged commit c4dac8f into main Mar 11, 2026
18 checks passed
@St0rmz1 St0rmz1 deleted the cleanup/rename-channels-to-secrets-props branch March 11, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename onChannelsChanged → onSecretsChanged across component tree

2 participants