Conversation
…tsChanged/dirtySecrets
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · 171,147 tokens |
pandemicsyn
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the
onChannelsChanged/dirtyChannelsprop and state pair toonSecretsChanged/dirtySecretsacrossClawDashboard.tsxandSettingsTab.tsx. Also renames the callback parameter fromchannelTypetoentryIdto match what it actually tracks (catalog entry IDs, not channel types).This fixes a naming mismatch introduced during the catalog migration —
SettingsTabwas receivingonChannelsChangedfrom its parent but passing it asonSecretsChangedtoSecretEntrySection. P1 cleanup item from the secret-catalog-registry plan.Verification
onChannelsChangedordirtyChannelsinsrc/Visual Changes
N/A
Reviewer Notes
DetailTilelabel are intentionally unchanged. Those describe the current secret category shown to users and will be revisited when non-channel categories (tools, providers) are addedSecretEntrySectionalready usedonSecretsChangedas its prop name — this rename just makes the parent chain consistent