fix(sidebar): prevent parent nav item from highlighting when child route is active#943
Open
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Open
fix(sidebar): prevent parent nav item from highlighting when child route is active#943kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
…ute is active The isActive logic used startsWith to match routes, causing parent items like 'Cloud Agent' (/cloud) to appear selected when visiting child routes like 'Sessions' (/cloud/sessions). Now a parent item is not marked active if a more specific sibling item matches the current pathname.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/cloud/sessions) also highlighted the Cloud Agent tab (/cloud) in the sidebarisActivecheck inSidebarMenuList.tsxusedpathname.startsWith(item.url + '/'), which caused parent route items to match when a more specific child route was activestartsWithmatch when a sibling nav item has a more specific URL that also matches the current pathname (longest prefix wins)Verification
pnpm typecheck— passesVisual Changes
N/A
Reviewer Notes
cc @markijbema
The same prefix-collision issue also affected the Webhooks tab (
/cloud/webhooks). This fix handles all such cases generically — any nav item whose URL is a prefix of another sibling item will defer to the more specific match.