Skip to content

Bump the minor group with 2 updates #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump the minor group with 2 updates #1648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cargo-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
name: cargo test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master

Check warning on line 26 in .github/workflows/cargo-test.yml

View workflow job for this annotation

GitHub Actions / zizmor

artipacked 

cargo-test.yml:26: credential persistence through GitHub Actions artifacts: does not set persist-credentials: false
- name: Install latest rust
uses: dtolnay/rust-toolchain@stable
with:
Expand All @@ -46,7 +46,7 @@
key: ${{ runner.os }}-cargo-build-target-${{ hashFiles('**/Cargo.lock') }}

- name: Login to GitHub Container Registry
uses: docker/login-action@v4
uses: docker/login-action@v4.1.0
with:
registry: ghcr.io
username: ${{ github.actor }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/generate-website-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,26 +11,26 @@
group: docs-${{ github.ref }}
cancel-in-progress: true
jobs:
generate-website-docs:

Check warning on line 14 in .github/workflows/generate-website-docs.yml

View workflow job for this annotation

GitHub Actions / zizmor

excessive-permissions 

generate-website-docs.yml:14: overly broad permissions: default permissions used due to no permissions: block
if: ${{ github.actor != 'dependabot[bot]' }}
name: make-release
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6

Check warning on line 19 in .github/workflows/generate-website-docs.yml

View workflow job for this annotation

GitHub Actions / zizmor

artipacked 

generate-website-docs.yml:19: credential persistence through GitHub Actions artifacts: does not set persist-credentials: false
- name: Install latest rust
uses: dtolnay/rust-toolchain@stable
- name: Cache cargo registry
uses: actions/cache@v5.0.5

Check failure on line 23 in .github/workflows/generate-website-docs.yml

View workflow job for this annotation

GitHub Actions / zizmor

cache-poisoning 

generate-website-docs.yml:23: runtime artifacts potentially vulnerable to a cache poisoning attack: enables caching by default
with:
path: ~/.cargo/registry
key: ${{ runner.os }}-cargo-registry-${{ hashFiles('**/Cargo.lock') }}
- name: Cache cargo index
uses: actions/cache@v5.0.5

Check failure on line 28 in .github/workflows/generate-website-docs.yml

View workflow job for this annotation

GitHub Actions / zizmor

cache-poisoning 

generate-website-docs.yml:28: runtime artifacts potentially vulnerable to a cache poisoning attack: enables caching by default
with:
path: ~/.cargo/git
key: ${{ runner.os }}-cargo-index-${{ hashFiles('**/Cargo.lock') }}
- name: Cache cargo build
uses: actions/cache@v5.0.5

Check failure on line 33 in .github/workflows/generate-website-docs.yml

View workflow job for this annotation

GitHub Actions / zizmor

cache-poisoning 

generate-website-docs.yml:33: runtime artifacts potentially vulnerable to a cache poisoning attack: enables caching by default
with:
path: target
key: ${{ runner.os }}-cargo-build-target-${{ hashFiles('**/Cargo.lock') }}
Expand All @@ -42,15 +42,15 @@
shell: bash
run: |
make gen-md
- uses: actions/create-github-app-token@v3.1.1
- uses: actions/create-github-app-token@v3.2.0

Check failure on line 45 in .github/workflows/generate-website-docs.yml

View workflow job for this annotation

GitHub Actions / zizmor

github-app 

generate-website-docs.yml:45: dangerous use of GitHub App tokens: app token inherits blanket installation permissions
id: app-token
with:
# required
app-id: ${{ secrets.GH_ORG_APP_ID }}
private-key: ${{ secrets.GH_ORG_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}

Check failure on line 51 in .github/workflows/generate-website-docs.yml

View workflow job for this annotation

GitHub Actions / zizmor

github-app 

generate-website-docs.yml:51: dangerous use of GitHub App tokens: token granted access to all repositories for this owner's app installation
# Checkout the docs repo since we will want to update the files there.
- uses: actions/checkout@v6

Check warning on line 53 in .github/workflows/generate-website-docs.yml

View workflow job for this annotation

GitHub Actions / zizmor

artipacked 

generate-website-docs.yml:53: credential persistence through GitHub Actions artifacts: does not set persist-credentials: false
with:
repository: 'kittycad/documentation'
path: 'docs'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/make-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
tags:
- v*
permissions:
contents: write

Check failure on line 6 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

excessive-permissions 

make-release.yml:6: overly broad permissions: contents: write is overly broad at the workflow level
name: make-release
jobs:
makerelease:
Expand Down Expand Up @@ -39,7 +39,7 @@

cargo install toml-cli
- name: Cache cargo registry
uses: actions/cache@v5.0.5

Check failure on line 42 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

cache-poisoning 

make-release.yml:42: runtime artifacts potentially vulnerable to a cache poisoning attack: enables caching by default
with:
path: ~/.cargo/registry
key: ${{ runner.os }}-cargo-registry-${{ hashFiles('**/Cargo.lock') }}
Expand All @@ -65,7 +65,7 @@
export VERSION=v$(toml get Cargo.toml package.version | jq -r .)
mkdir -p releases/$(basename $(pwd))
cp -r cross releases/$(basename $(pwd))/${VERSION}
cp cross/README.md cross/${{matrix.os}}-${{github.ref_name}}-README.md

Check failure on line 68 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

template-injection 

make-release.yml:68: code injection via template expansion: may expand into attacker-controllable code
- name: 'upload binary files'
id: upload-files
uses: google-github-actions/upload-cloud-storage@v3.0.0
Expand Down Expand Up @@ -112,8 +112,8 @@
ls -la
echo 'These instructions are meant as an easy way to install. Unix snippets use `sha256sum`; macOS users may need `coreutils` for that command.' > release.md
echo "" >> release.md
cat macos-latest-${{github.ref_name}}-README.md \

Check failure on line 115 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

template-injection 

make-release.yml:115: code injection via template expansion: may expand into attacker-controllable code
ubuntu-latest-${{github.ref_name}}-README.md \

Check failure on line 116 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

template-injection 

make-release.yml:116: code injection via template expansion: may expand into attacker-controllable code
>> release.md
rm build/*-README.md
rm build/README.md
Expand All @@ -133,7 +133,7 @@
fi
fi
- name: Create a Release
uses: softprops/action-gh-release@v3.0.0

Check notice on line 136 in .github/workflows/make-release.yml

View workflow job for this annotation

GitHub Actions / zizmor

superfluous-actions 

make-release.yml:136: action functionality is already included by the runner: use `gh release` in a script step
with:
body_path: ${{github.workspace}}/release.md
prerelease: ${{steps.extract_prerelease.outputs.prerelease}}
Expand Down Expand Up @@ -221,7 +221,7 @@
with:
path: releases
destination: dl.kittycad.io
- uses: actions/create-github-app-token@v3.1.1
- uses: actions/create-github-app-token@v3.2.0
id: app-token
with:
# required
Expand Down
Loading