Skip to content

Skip serializing if draftAngle is None #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamchalmers merged 1 commit into from
May 26, 2026
+2 −3
Merged

Skip serializing if draftAngle is None #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modeling-cmds/openapi/api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2635,7 +2635,6 @@
"draft_angle": {
"nullable": true,
"description": "What draft angle should be used in this extrusion? Negative values indicate an outward draft, while positive values indicate an inward draft",
"default": null,
"allOf": [
{
"$ref": "#/components/schemas/Angle"
Expand Down
4 changes: 2 additions & 2 deletions modeling-cmds/src/def_enum.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ define_modeling_cmd_enum! {
/// How far off the plane to extrude
pub distance: LengthUnit,
/// What draft angle should be used in this extrusion?
/// Negative values indicate an outward draft,
/// Negative values indicate an outward draft,
/// while positive values indicate an inward draft
#[serde(default)]
#[serde(default, skip_serializing_if = "Option::is_none")]
pub draft_angle: Option<Angle>,
/// Which IDs should the new faces have?
/// If this isn't given, the engine will generate IDs.
Expand Down