Skip to content

Fix deletion of loft caps#10748

Merged
pierremtb merged 4 commits intomainfrom
pierremtb/issue10720-delete-loft-cap
Apr 8, 2026
Merged

Fix deletion of loft caps#10748
pierremtb merged 4 commits intomainfrom
pierremtb/issue10720-delete-loft-cap

Conversation

@pierremtb
Copy link
Copy Markdown
Contributor

Closes #10720

@pierremtb pierremtb requested a review from a team as a code owner April 2, 2026 04:09
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modeling-app Ready Ready Preview, Comment Apr 7, 2026 5:54pm

Request Review

@max-mrgrsk
Copy link
Copy Markdown
Contributor

max-mrgrsk commented Apr 2, 2026

so there are 3 bugs here:

  • tagEnd is not working even in kcl
  • code mod is tagging only tagStart what ever cap you are clicking
  • code mod is using the original body on each delete instead of the name of it's last mutation

I have a gut feeling that second one is connected to the first and third bug is not critical problem so maybe the PR can be approved

reference to tagEnd problem: https://github.com/KittyCAD/engine/issues/4358#issuecomment-4173104911

tagEnd.mp4

Copy link
Copy Markdown
Contributor

@max-mrgrsk max-mrgrsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it is a bigger issue, we can merge it as is and fix the rest over:

@pierremtb pierremtb merged commit d27a638 into main Apr 8, 2026
58 checks passed
@pierremtb pierremtb deleted the pierremtb/issue10720-delete-loft-cap branch April 8, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Delete Face] Can not delete faces of loft with point and click

2 participants