Closed
Conversation
This was bothering me while testing the app late at night, so I had Codex write the inline styles that we need to get user theme to be honored before JS or anything else loads.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jacebrowning
reviewed
Apr 3, 2026
Contributor
There was a problem hiding this comment.
Some of the text in the snapshot has gone from light to dark. Maybe you can find a way to prevent this?
Contributor
|
I grabbed the desktop app build from https://github.com/KittyCAD/modeling-app/actions/runs/23935022534/job/69809706995, I'm not convinced this fully it Screen.Recording.2026-04-03.at.10.55.56.AM.mov |
Contributor
Author
|
@pierremtb sorry I should have given it more top billing: I have a note in the description that this just fixes the issue on web, not electron. @jacebrowning thanks for marking this as draft yeah I need to investigate the base styles for the text and whatnot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was bothering me while testing the app late at night, so I had Codex write the inline styles that we need to get user theme to be honored before JS or anything else loads.
Note: this does not fix a separate flash-of-light that occurs in the desktop app Electron window. That will need to be investigated further, I'm not as clear on how to fix it.
Demo (ow)
Screenshare.-.2026-04-03.1_06_36.AM-compressed.mp4