Compensate for scrollbar width across all asterisked columns instead of just the last one#263
Open
steverice wants to merge 1 commit intoKnockout-Contrib:masterfrom
Open
Compensate for scrollbar width across all asterisked columns instead of just the last one#263steverice wants to merge 1 commit intoKnockout-Contrib:masterfrom
steverice wants to merge 1 commit intoKnockout-Contrib:masterfrom
Conversation
…of just the last one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calculating widths for columns with asterisks, the existing code checks to see if the column under consideration is the last column in the grid. If so and the vertical scroll bar is being shown it will reduce that column's width so that it does not cause horizontal overflow.
This pull request shifts the compensation to all asterisked columns, which both reduces the effect on any single column (if there are more than one) and allows the compensation to happen if there is a fixed- or percentage-width column at the rightmost end of the grid, given that there are asterisked columns elsewhere in the grid.