Open
Conversation
rennf93
reviewed
Feb 23, 2026
| @@ -1,4 +1,4 @@ | |||
| import os | |||
| # import os | |||
rennf93
reviewed
Feb 23, 2026
| import logging | ||
| from pathlib import Path | ||
| from typing import Dict, Optional | ||
| from typing import Dict |
There was a problem hiding this comment.
Use dict() instead of importing and using Dict - Unless it's a python version compatibility workaround
rennf93
reviewed
Feb 23, 2026
Comment on lines
+3
to
+4
| # If you don't use import, comment them | ||
| # import sys |
There was a problem hiding this comment.
Remove this comment and the commented out import. Both are unnecessary
rennf93
reviewed
Feb 23, 2026
| from typing import Dict | ||
|
|
||
| from main import USBDetector | ||
| from config import * |
There was a problem hiding this comment.
Using "... import *" is in general considered bad practice. Please try importing exact names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a missed import, do some type hinting & ruff formating