Merged
Conversation
2. Updated RTSDK links to be updated 3. Added JavaFX requirement and run information 4. Added JavaFX dependency to pom.xml
|
i was about to do the same. include java-fx to the dependencies, its where it SHOULD be. the project is not only not-buildable, it's not even non-navigable without this.
|
|
@wasin-waeosri your PR seems to be LLM generated, elaborate? limit the scope plz. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Added JavaFX library requirement, and how to run with JavaFX to README.md file
• Updated all RTSDK links in the README.md file to be updated and rebranded some Refinitiv term.
• Added JavaFX dependencies to the pom.xml file for building with Java 11+ versions.