fix: Refresh Group Members 0xfe7_3 0x899_PARAMETER_WRONG#112
Open
kengwang wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the TRPC service identifier used by FetchGroupMembersService to target a newer OIDB route for fetching group members.
Changes:
- Switched the
[Service]attribute fromOidbSvcTrpcTcp.0xfe7_3toOidbSvcTrpcTcp.0xfe7_4.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| [EventSubscribe<FetchGroupMembersEventReq>(Protocols.All)] | ||
| [Service("OidbSvcTrpcTcp.0xfe7_3")] | ||
| [Service("OidbSvcTrpcTcp.0xfe7_4")] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a member joined a group, it will trigger an error
What's been done
It seems that
OidbSvcTrpcTcp.0xfe7_4is the new cmd of fetching member. Change to it, resulting no errors anymoe.