-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Adds litlogger integration #21430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds litlogger integration #21430
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟢 pytorch_lightning: lit GPU
These checks are required after the changes to 🟢 Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 install
These checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21430 +/- ##
=========================================
- Coverage 87% 79% -8%
=========================================
Files 269 267 -2
Lines 23875 24004 +129
=========================================
- Hits 20689 18952 -1737
- Misses 3186 5052 +1866 |
e23fc12 to
e54ffb1
Compare
834485a to
c984e9c
Compare
c984e9c to
e1444f3
Compare
williamFalcon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been waiting 7 years for this lol
What does this PR do?
Integrates LitLogger as a first-class logger to pytorch-lightning.
Users will be able to log directly to lightning.ai from pytorch_lightning without any additional setup.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21430.org.readthedocs.build/en/21430/