Skip to content

Conversation

@justusschock
Copy link
Member

@justusschock justusschock commented Dec 18, 2025

What does this PR do?

Integrates LitLogger as a first-class logger to pytorch-lightning.

Users will be able to log directly to lightning.ai from pytorch_lightning without any additional setup.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21430.org.readthedocs.build/en/21430/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to requirements/pytorch/loggers.info, src/lightning/pytorch/loggers/__init__.py, src/lightning/pytorch/loggers/litlogger.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/logger_connector/logger_connector.py, tests/tests_pytorch/loggers/conftest.py, tests/tests_pytorch/loggers/test_litlogger.py.

🟢 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, pytorch, 3.10) success
pytorch.yml / Lit Job (lightning, 3.12) success
pytorch.yml / Lit Job (pytorch, 3.12) success

These checks are required after the changes to requirements/pytorch/loggers.info, src/lightning/pytorch/loggers/__init__.py, src/lightning/pytorch/loggers/litlogger.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/logger_connector/logger_connector.py, tests/tests_pytorch/loggers/conftest.py, tests/tests_pytorch/loggers/test_litlogger.py.

🟢 Benchmarks
Check ID Status
benchmark.yml / Lit Job (fabric) success
benchmark.yml / Lit Job (pytorch) success

These checks are required after the changes to requirements/pytorch/loggers.info, src/lightning/pytorch/loggers/__init__.py, src/lightning/pytorch/loggers/litlogger.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/logger_connector/logger_connector.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to docs/source-fabric/conf.py, docs/source-fabric/glossary/index.rst, docs/source-fabric/guide/loggers/litlogger.rst, docs/source-fabric/guide/logging.rst.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/loggers/__init__.py, src/lightning/pytorch/loggers/litlogger.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/logger_connector/logger_connector.py, docs/source-pytorch/api_references.rst, docs/source-pytorch/conf.py, docs/source-pytorch/extensions/logging.rst, docs/source-pytorch/visualize/supported_exp_managers.rst, requirements/pytorch/loggers.info.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to requirements/pytorch/loggers.info, src/lightning/pytorch/loggers/__init__.py, src/lightning/pytorch/loggers/litlogger.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/logger_connector/logger_connector.py.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to src/lightning/pytorch/loggers/__init__.py, src/lightning/pytorch/loggers/litlogger.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/logger_connector/logger_connector.py, requirements/pytorch/loggers.info.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 70 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 92.55319% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 79%. Comparing base (a6701aa) to head (1d27dc8).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (a6701aa) and HEAD (1d27dc8). Click for more details.

HEAD has 395 uploads less than BASE
Flag BASE (a6701aa) HEAD (1d27dc8)
cpu 120 29
lightning 60 14
pytest 60 0
python3.11 24 6
lightning_fabric 30 0
python3.12 36 9
python3.10 12 3
python3.12.7 36 8
python 12 3
pytorch2.2.2 6 3
pytest-full 60 29
pytorch2.1 12 6
pytorch2.3 6 3
pytorch2.9 6 3
pytorch_lightning 30 15
pytorch2.5.1 6 3
pytorch2.4.1 6 2
pytorch2.8 6 3
pytorch2.7 6 3
pytorch2.6 6 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21430     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         269      267      -2     
  Lines       23875    24004    +129     
=========================================
- Hits        20689    18952   -1737     
- Misses       3186     5052   +1866     

@github-actions github-actions bot added the docs Documentation related label Dec 19, 2025
@github-actions github-actions bot added ci Continuous Integration fabric lightning.fabric.Fabric dependencies Pull requests that update a dependency file package labels Dec 19, 2025
@justusschock justusschock force-pushed the integrate_lit_logger branch 8 times, most recently from 834485a to c984e9c Compare December 19, 2025 12:26
Copy link
Contributor

@williamFalcon williamFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been waiting 7 years for this lol

https://github.com/williamFalcon/test-tube

@justusschock justusschock merged commit 2e25642 into master Dec 20, 2025
87 checks passed
@justusschock justusschock deleted the integrate_lit_logger branch December 20, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration dependencies Pull requests that update a dependency file docs Documentation related fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants