Skip to content

Conversation

@NikitaR28
Copy link
Contributor

Summary

Preparation to cover Esports Awards and other awards show on esports wiki
Link to discord conversation: https://discord.com/channels/93055209017729024/824979065307136010/1465711192134909952

How did you test this change?

dev module and userspace page: https://liquipedia.net/esports/User:Nikita_r28/Esports_Awards/Decade
(code is Tier/Data from commons + last entry from rainbowsix Tier/Data)

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do pages about award shows apparently use infobox league?
to me that seems wrong data wise ...
that might cause issues with quite a few templates/modules ...

which of the tier types are actually needed?

@NikitaR28
Copy link
Contributor Author

why do pages about award shows apparently use infobox league? to me that seems wrong data wise ... that might cause issues with quite a few templates/modules ...

They are using Infobox league so awards can be shown on team pages via Team awards table, and for using TournamentsList like on these wikis
https://liquipedia.net/formula1/Portal:Championships/Miscellaneous_Events
https://liquipedia.net/rainbowsix/Award_Shows

which of the tier types are actually needed?

So far only Awards (others taken from commons module and currently not used)

@NikitaR28
Copy link
Contributor Author

@hjpalpha do I need to remove all unused tiertypes?

@hjpalpha
Copy link
Collaborator

i am not a fan of using infobox league for this at all
i will add it as a discussion topic for february modules sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants