Skip to content

feat(infobox): Support unclear tournament dates#7029

Draft
mbergen wants to merge 2 commits intomainfrom
league-unclear-date
Draft

feat(infobox): Support unclear tournament dates#7029
mbergen wants to merge 2 commits intomainfrom
league-unclear-date

Conversation

@mbergen
Copy link
Collaborator

@mbergen mbergen commented Feb 1, 2026

Summary

Module:Tournament already supports reading from extradata.startdatetext:

local startDate = Tournament.parseDateRecord(Logic.nilOr(extradata.startdatetext, record.startdate))
local endDate = Tournament.parseDateRecord(Logic.nilOr(extradata.enddatetext, record.sortdate, record.enddate))

Implementation moved from R6 to commons.

TODO:

How did you test this change?

TBD

Moved the implementation from R6 custom to commons
@mbergen mbergen linked an issue Feb 1, 2026 that may be closed by this pull request
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on phone

@Rathoz
Copy link
Collaborator

Rathoz commented Feb 2, 2026

CS has a custom implementation too right? And maybe some other wikis

@mbergen
Copy link
Collaborator Author

mbergen commented Feb 2, 2026

CS has a custom implementation too right? And maybe some other wikis

Right, will check again.
Welcome back!

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
do we need to adjust any modules on cs/val that use extradata.startdate_raw or extradata.enddate_raw?

@mbergen
Copy link
Collaborator Author

mbergen commented Feb 3, 2026

lgtm do we need to adjust any modules on cs/val that use extradata.startdate_raw or extradata.enddate_raw?

Only CS has any consumers of that are still in use (see TODO in the description).
I'm discussing whether these can be swapped to the standard TournamentsListing.

@Rathoz
Copy link
Collaborator

Rathoz commented Feb 4, 2026

RFM or need prep work?

@mbergen
Copy link
Collaborator Author

mbergen commented Feb 4, 2026

RFM or need prep work?

Still need to adjust the two modules linked and test this

@Rathoz
Copy link
Collaborator

Rathoz commented Feb 4, 2026

Ok, let me know when you want this merged

@Rathoz Rathoz marked this pull request as draft February 5, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support unclear dates for tournaments

3 participants