feat(infobox): Support unclear tournament dates#7029
Draft
Conversation
Moved the implementation from R6 custom to commons
Collaborator
|
CS has a custom implementation too right? And maybe some other wikis |
Collaborator
Author
Right, will check again. |
hjpalpha
approved these changes
Feb 3, 2026
Collaborator
hjpalpha
left a comment
There was a problem hiding this comment.
lgtm
do we need to adjust any modules on cs/val that use extradata.startdate_raw or extradata.enddate_raw?
Collaborator
Author
Only CS has any consumers of that are still in use (see TODO in the description). |
Rathoz
approved these changes
Feb 4, 2026
Collaborator
|
RFM or need prep work? |
Collaborator
Author
Still need to adjust the two modules linked and test this |
Collaborator
|
Ok, let me know when you want this merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Module:Tournament already supports reading from extradata.startdatetext:
Lua-Modules/lua/wikis/commons/Tournament.lua
Lines 120 to 121 in 4558591
Implementation moved from R6 to commons.
TODO:
How did you test this change?
TBD