fix(ParticipantTable): placement fetching faulty #7062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectricalBoy
approved these changes
Feb 9, 2026
Rathoz
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
placement fetching currently is faulty for duo/trio/quad opponents with players that have spaces/underscores
example:
opponentname
HerO_(Kim_Joon_Ho) / Maruwhat the parttable checks for:
HerO (Kim Joon Ho) / MaruorHerO_(Kim_Joon_Ho)_/_Maruin the past (before we added
Page.applyUnderScoresIfEnforcedwith #5854) on sc and sc2 we did a:gsub(' ', '_')in matches and prize pools to determine the opponentnamewith
Page.applyUnderScoresIfEnforcedwe now do the gsub on the playernames before concatting themapparently i forgot to adjust the participant tale when intorducing
Page.applyUnderScoresIfEnforcedreport on discord:
https://discord.com/channels/93055209017729024/213614988647071744/1470085617395171389
(points not getting stored for a duo opponent due to above mentioned issue))
How did you test this change?
dev
reminder for myself (for after merge):