-
Notifications
You must be signed in to change notification settings - Fork 101
feat: add player tournament appearances #7071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: SyntacticSalt <mail@mbergen.de>
hjpalpha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do i assume correctly that the args are named as they are for them being already used?
(they do not follow a scheme, some all lower, some snake case etc pp)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should likely use widgets instead of mw.html stuff (e.g. in row function)
yes, see ca001ac...8c5104f |
hjpalpha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shit to check on phone hence just the question
do we display the link to query form even if it comed from query?
short answer: no form silently passes Lua-Modules/lua/wikis/commons/PlayerTournamentAppearances.lua Lines 69 to 75 in cac081e
|
actually the Lua-Modules/lua/wikis/commons/PlayerTournamentAppearances.lua Lines 281 to 283 in cac081e
and we actually need Lua-Modules/lua/wikis/commons/Placement.lua Lines 164 to 178 in 86a6d41
|
Summary
This PR adds Module:PlayerTournamentAppearances to this repository.
How did you test this change?
preview with dev