Require password when deleting account#1054
Open
Toastbrot236 wants to merge 3 commits intoLittleBigRefresh:mainfrom
Open
Require password when deleting account#1054Toastbrot236 wants to merge 3 commits intoLittleBigRefresh:mainfrom
Toastbrot236 wants to merge 3 commits intoLittleBigRefresh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For security reasons, this PR makes requests to the user's own account deletion endpoint require a body with a SHA512 hash of the user's password, regardless of whether they are already authenticated. This does alter APIv3 spec, but it's likely not a widely used endpoint. A complementary PR for the refresh-web legacy branch will be opened alongside this one.