fix: Settings Button moved to YouTube Chat menu#195
Closed
XangelMusic wants to merge 4 commits intoLiveTL:mainfrom
Closed
fix: Settings Button moved to YouTube Chat menu#195XangelMusic wants to merge 4 commits intoLiveTL:mainfrom
XangelMusic wants to merge 4 commits intoLiveTL:mainfrom
Conversation
r2dev2
reviewed
Jan 24, 2026
Member
r2dev2
left a comment
r2dev2
left a comment
There was a problem hiding this comment.
Some comments, will review more comprehensively later tn.
src/components/SettingsButton.svelte
Outdated
Comment on lines
34
to
35
| /* youtube studio dropdown popups use different color for hover */ | ||
| ytls-menu-popup-renderer .button:hover { |
Member
There was a problem hiding this comment.
To target ytls-menu-popup-renderer, use :global(ytls-menu-popup-renderer).
From dm: as this is youtube studio, we might not care about this use case, so potentially yeet?
@KentoNishi do you think we need this for yt studio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.