build(windows): add arm64 support#3905
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
0ccee19 to
4039fec
Compare
b158d6d to
283ab4c
Compare
|
Can we use this hardware encode? 🤔 |
|
I think MF encoder is already included with the FFmpeg build, so why not? |
Well, I didn't read the source code of sunshine. |
This comment was marked as resolved.
This comment was marked as resolved.
9d0c82c to
b0e2234
Compare
48376c4 to
a3ee774
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Add CI build for Windows ARM64. Signed-off-by: Coia Prant <coiaprant@gmail.com> Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Add windows arm64 documents. Signed-off-by: Coia Prant <coiaprant@gmail.com> Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
|
Thank you. Please no more force pushing. |
|
Thanks, I went back to sleep. |
Insert a 'Debug nsis' step into .github/workflows/ci-windows.yml that always runs and prints the NSISOutput.log using the msys2 shell. This captures NSIS installer build logs for troubleshooting; the step uses '|| true' to avoid failing the job. The step is placed before the existing 'Debug wix' step.
Make NSIS detailed logging conditional on the target architecture by adding NSIS_LOGSET_COMMAND (set to "LogSet on" only when CMAKE_SYSTEM_PROCESSOR matches AMD64) and using it in CPACK_NSIS_EXTRA_INSTALL_COMMANDS and CPACK_NSIS_EXTRA_UNINSTALL_COMMANDS instead of always calling LogSet. Update docs/getting_started.md to note that the install.log under %PROGRAMFILES% is available on AMD64 only.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3905 +/- ##
=========================================
Coverage ? 14.11%
=========================================
Files ? 95
Lines ? 19859
Branches ? 9189
=========================================
Hits ? 2804
Misses ? 13523
Partials ? 3532
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@rbqvq unfortunately, now arm64 is failing in Debian/Ubuntu images. We don't build these for PRs because they take 3+ hours. Do you have some idea how we can conditionally use these additions to the package.json? "@rollup/wasm-node": "4.57.1"
},
"overrides": {
"rollup": "npm:@rollup/wasm-node@4.57.1" |
|
I think we can provide two package.json and use script to rename them. |
|
Can we have a second package.json that depends on the first one? And use second one only when we need the override? If we can reduce the duplication that would be ideal. |
|
Or we can build them on a unified CI, and the CI of each OS builder only needs to pull the static resources that have been built. |
Use actions/setup-node instead of MSYS2. Revert commit `fix(build): using @rollup/wasm-node` partial changes in LizardByte#3905 Signed-off-by: Coia Prant <coiaprant@gmail.com>
Use actions/setup-node instead of MSYS2. Revert commit `fix(build): using @rollup/wasm-node` partial changes in LizardByte#3905 Signed-off-by: Coia Prant <coiaprant@gmail.com>
|
@ReenigneArcher It should be fix in #4687 Actions for windows build still working: |
Use actions/setup-node instead of MSYS2. Revert commit `fix(build): using @rollup/wasm-node` partial changes in LizardByte#3905 Signed-off-by: Coia Prant <coiaprant@gmail.com>
Use actions/setup-node instead of MSYS2. Revert commit `fix(build): using @rollup/wasm-node` partial changes in LizardByte#3905 Signed-off-by: Coia Prant <coiaprant@gmail.com>
Use actions/setup-node instead of MSYS2. Revert commit `fix(build): using @rollup/wasm-node` partial changes in LizardByte#3905 Signed-off-by: Coia Prant <coiaprant@gmail.com>
Use actions/setup-node instead of MSYS2. Revert commit `fix(build): using @rollup/wasm-node` partial changes in LizardByte#3905 Signed-off-by: Coia Prant <coiaprant@gmail.com>
Use actions/setup-node instead of MSYS2. Revert commit `fix(build): using @rollup/wasm-node` partial changes in LizardByte#3905 Signed-off-by: Coia Prant <coiaprant@gmail.com>
Use actions/setup-node instead of MSYS2. Revert commit `fix(build): using @rollup/wasm-node` partial changes in LizardByte#3905 Signed-off-by: Coia Prant <coiaprant@gmail.com>
Use actions/setup-node instead of MSYS2. Revert commit `fix(build): using @rollup/wasm-node` partial changes in LizardByte#3905 Signed-off-by: Coia Prant <coiaprant@gmail.com>



Description
This PR adds an arm64 build for Windows.
Issues Fixed or Closed
Type of Change
.github/...)Checklist