Skip to content

chores: drop unused nvenc(ffmpeg) encoder#4731

Closed
rbqvq wants to merge 1 commit intoLizardByte:masterfrom
rbqvq:master
Closed

chores: drop unused nvenc(ffmpeg) encoder#4731
rbqvq wants to merge 1 commit intoLizardByte:masterfrom
rbqvq:master

Conversation

@rbqvq
Copy link
Contributor

@rbqvq rbqvq commented Feb 15, 2026

Description

drop unused nvenc(ffmpeg) encoder

It never be used on Windows, drop it.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

It never be used on Windows, drop it.

Signed-off-by: Coia Prant <coiaprant@gmail.com>
@rbqvq
Copy link
Contributor Author

rbqvq commented Feb 15, 2026

TODO: #4732

AV_HWDEVICE_TYPE_D3D11VA,
AV_HWDEVICE_TYPE_NONE,
AV_PIX_FMT_D3D11,
#else
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep these. I've used them in the past when debugging to switch between our standalone NVENC implementation and FFmpeg to compare behavior.

@rbqvq rbqvq changed the title encoder: drop unused code and using low_latency for mediafoundation encoder: drop unused code Feb 16, 2026
@rbqvq rbqvq changed the title encoder: drop unused code chores: drop unused nvenc(ffmpeg) encoder Feb 16, 2026
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants