Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
===========================================
+ Coverage 62.01% 74.25% +12.23%
===========================================
Files 4 4
Lines 337 404 +67
Branches 63 77 +14
===========================================
+ Hits 209 300 +91
+ Misses 92 65 -27
- Partials 36 39 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ReenigneArcher
force-pushed
the
test/add-screenshots
branch
29 times, most recently
from
d361a0c to
c6d4b9b
Compare
ReenigneArcher
force-pushed
the
test/add-screenshots
branch
7 times, most recently
from
a14e0a8 to
5d082c1
Compare
ReenigneArcher
force-pushed
the
test/add-screenshots
branch
5 times, most recently
from
d7ae591 to
bcc76cf
Compare
Adds logic to create an invisible toplevel window as an anchor for the tray menu, ensuring compatibility with AppIndicator and headless environments. Uses modern GTK API when available and falls back to legacy methods as needed.
ReenigneArcher
force-pushed
the
test/add-screenshots
branch
from
bcc76cf to
be900e8
Compare
Tray items on macOS now display a tooltip if the 'tooltip' field is set. This improves user experience by providing additional context when hovering over the tray icon.
Eliminated unnecessary tray_loop(1) calls in unit tests for tooltip, checkbox, and icon updates. WaitForTrayReady is sufficient for synchronization, simplifying the test logic.
Updated tray_exit to remove the status item from the status bar using dispatch_async on the main thread, ensuring thread safety for NSStatusBar operations.
ReenigneArcher
force-pushed
the
test/add-screenshots
branch
from
569a0cb to
0707475
Compare
Replaces or removes calls to tray_loop(1) in unit tests to prevent hanging during test execution. The TestTrayLoop now uses tray_loop(0) for non-blocking behavior, and other tests no longer invoke tray_loop, improving test reliability and speed.
Updated tray_exit to check if the current thread is the main thread before removing the status item. If not on the main thread, the removal is dispatched synchronously to the main thread to ensure thread safety.
ReenigneArcher
force-pushed
the
test/add-screenshots
branch
from
d9aa1a1 to
d936f97
Compare
Enhanced the WaitForTrayReady method to handle macOS (AppKit) by adding a delay, ensuring the tray icon appears before screenshots. Updated comments for clarity and maintained Linux (AppIndicator) event processing.
ReenigneArcher
force-pushed
the
test/add-screenshots
branch
3 times, most recently
from
7677502 to
d86ae2f
Compare
Introduces a step to grant screen recording permissions on macOS runners by modifying the TCC database, preventing popup dialogs during CI runs. This ensures smoother automated workflows and addresses issues with screen capture access in GitHub Actions.
ReenigneArcher
force-pushed
the
test/add-screenshots
branch
from
d86ae2f to
bc45f66
Compare
Introduces an appindicator_type variable to the CI matrix for distinguishing between 'ayatana' and 'legacy' appindicator packages. Passes this variable to the setup_virtual_desktop action to allow for more flexible environment configuration.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds screenshots to tests. The goal is to be able to easily review what the tray icon looks like in different states.
TODO:
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage