Skip to content

fix: bail-out from async createLottie after unmount#104

Open
Andarist wants to merge 1 commit into
LottieFiles:masterfrom
Andarist:fix/set-state-after-unmount
Open

fix: bail-out from async createLottie after unmount#104
Andarist wants to merge 1 commit into
LottieFiles:masterfrom
Andarist:fix/set-state-after-unmount

Conversation

@Andarist

@Andarist Andarist commented Jul 9, 2022

Copy link
Copy Markdown

Description

Without this we might end up with a warning in older versions of React:

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)

Checklist

  • This is something we need to do.

@github-actions

github-actions Bot commented Sep 8, 2022

Copy link
Copy Markdown

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions Bot added the stale label Sep 8, 2022
@Andarist

Andarist commented Sep 8, 2022

Copy link
Copy Markdown
Author

Bump for stale bot

@github-actions github-actions Bot removed the stale label Sep 9, 2022
@github-actions

github-actions Bot commented Nov 9, 2022

Copy link
Copy Markdown

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions Bot added the stale label Nov 9, 2022
@Andarist

Andarist commented Nov 9, 2022

Copy link
Copy Markdown
Author

Bump

@github-actions github-actions Bot removed the stale label Nov 10, 2022
@github-actions

Copy link
Copy Markdown

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions Bot added the stale label Jan 10, 2023
@Andarist

Copy link
Copy Markdown
Author

Bump

@github-actions github-actions Bot removed the stale label Jan 11, 2023
@github-actions

Copy link
Copy Markdown

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions Bot added the stale label Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant